The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivetkit-serverless	Error			Oct 3, 2025 7:46pm

Claude finished @abcxff's task —— View job

Code Review Complete ✅

I've reviewed the Deno counter example implementation. Here's my comprehensive feedback:

Todo List:

• Read and analyze all changed files
• Review against RivetKit development guidelines
• Check example structure and naming conventions
• Evaluate Deno-specific implementation
• Assess security considerations
• Review test coverage and quality
• Provide comprehensive feedback

🔍 Overall Assessment

This is a solid Deno example that demonstrates RivetKit basics with a simple counter actor. The implementation follows most RivetKit conventions but has several issues that need attention.

🚨 Critical Issues

1. Package Naming Convention Violation (examples/deno/package.json:2)

   "name": "deno-counter"  // ❌ Should be "example-deno"

   Per CLAUDE.md guidelines: "Always name the example example-{name}"

2. Incorrect Dependency Declaration (examples/deno/package.json:17)

   "rivetkit": "2.0.6"  // ❌ Should be "workspace:*"

   Per CLAUDE.md: "Always use workspace:* for dependencies"

3. Missing turbo.json File
   All examples should include a turbo.json file with the specified content from CLAUDE.md.

🧪 Test Coverage Issues

1. All Tests Commented Out (examples/deno/tests/deno.test.ts:1-47)

   • The entire test suite is commented out, providing zero test coverage
   • Tests appear functional but are disabled without explanation
   • This violates the expectation of working examples

2. Missing Test Dependencies (examples/deno/package.json)

   • No test-related dependencies declared despite having test files
   • The commented tests import from jsr:@std/assert but it's not in dependencies

⚠️ Code Quality Issues

1. Inconsistent Script Implementation (examples/deno/scripts/connect.ts:4-20)

   • Contains commented-out code with event handling functionality
   • Current implementation lacks the event listening demo from the commented version
   • Should either remove commented code or explain why it's there

2. Missing Task in deno.json (examples/deno/deno.json)

   • No connect task defined despite README referencing deno task connect
   • README instructions won't work as written

3. Dependency Version Inconsistency

   • Uses specific version "2.0.6" instead of workspace reference
   • Inconsistent with other examples in the repository

🔧 Best Practices & Performance

Positives:

• Clean actor implementation with proper state management
• Correct use of broadcast for event emission
• Appropriate Deno permissions in scripts
• Good TypeScript configuration with strict mode

Areas for Improvement:

• Consider adding error handling in the increment action
• The server startup could benefit from error handling and logging

🛡️ Security Assessment

Good:

• Minimal, appropriate Deno permissions requested
• No hardcoded secrets or sensitive data
• Proper type safety with TypeScript strict mode

Concerns:

• The broad --allow-net permission could be more restrictive for a local example
• Consider documenting why each permission is needed

📋 Recommendations

1. Fix naming convention: Rename package to example-deno
2. Use workspace dependencies: Change rivetkit dependency to workspace:*
3. Add missing turbo.json with the required configuration
4. Enable tests: Uncomment and fix the test suite
5. Add connect task: Add "connect": "deno --allow-env --allow-sys --allow-read --allow-ffi --allow-net run scripts/connect.ts" to deno.json
6. Clean up commented code: Either remove or document why it exists
7. Add error handling: Improve robustness in server.ts and connect.ts

📚 Documentation

The README follows the template well but has one issue:

• Instructions reference deno task connect which isn't defined in deno.json

✅ What Works Well

• Clean, minimal actor implementation
• Proper RivetKit patterns and conventions
• Good project structure
• Comprehensive TypeScript configuration
• Clear separation of concerns between server and client

This example has good bones but needs the above fixes to meet RivetKit's example standards and provide a working demonstration for users.

• feat(examples): deno counter #1291 👈 (View in Graphite)
• chore(core): disable printing endpoint if default server disabled #1338
• main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

This stack of pull requests is managed by Graphite. Learn more about stacking.

KIT-297 RivetKit Deno example

Claude finished @abcxff's task —— View job

Code Review Complete ✅

I've reviewed the Deno counter example implementation. Here's my comprehensive feedback:

🔍 Overall Assessment

This is a solid Deno example that demonstrates RivetKit basics with a simple counter actor. The implementation follows most RivetKit conventions but has several issues that need attention.

🚨 Critical Issues

1. Package Naming Convention Violation (examples/deno/package.json:3)

   "name": "deno-counter"  // ❌ Should be "example-deno"

   Per CLAUDE.md guidelines: "Always name the example example-{name}"

2. Incorrect Dependency Declaration (examples/deno/package.json:18)

   "rivetkit": "2.0.6"  // ❌ Should be "workspace:*"

   Per CLAUDE.md: "Always use workspace:* for dependencies"

3. Missing turbo.json File
   All examples should include a turbo.json file with the specified content from CLAUDE.md.

🧪 Test Coverage Issues

1. All Tests Commented Out (examples/deno/tests/deno.test.ts:1-47)

   • The entire test suite is commented out, providing zero test coverage
   • Tests appear functional but are disabled without explanation
   • This violates the expectation of working examples

2. Missing Test Dependencies (examples/deno/package.json)

   • No test-related dependencies declared despite having test files
   • The commented tests import from jsr:@std/assert but it's not in dependencies

⚠️ Code Quality Issues

1. Inconsistent Script Implementation (examples/deno/scripts/connect.ts:4-20)

   • Contains commented-out code with event handling functionality
   • Current implementation lacks the event listening demo from the commented version
   • Should either remove commented code or explain why it's there

2. Missing Task in deno.json (examples/deno/deno.json)

   • No connect task defined despite README referencing deno task connect
   • README instructions won't work as written

3. Dependency Version Inconsistency

   • Uses specific version "2.0.6" instead of workspace reference
   • Inconsistent with other examples in the repository

🔧 Best Practices & Performance

Positives:

• Clean actor implementation with proper state management
• Correct use of broadcast for event emission
• Appropriate Deno permissions in scripts
• Good TypeScript configuration with strict mode

Areas for Improvement:

• Consider adding error handling in the increment action
• The server startup could benefit from error handling and logging

🛡️ Security Assessment

Good:

• Minimal, appropriate Deno permissions requested
• No hardcoded secrets or sensitive data
• Proper type safety with TypeScript strict mode

Concerns:

• The broad --allow-net permission could be more restrictive for a local example
• Consider documenting why each permission is needed

📋 Recommendations

1. Fix naming convention: Rename package to example-deno
2. Use workspace dependencies: Change rivetkit dependency to workspace:*
3. Add missing turbo.json with the required configuration
4. Enable tests: Uncomment and fix the test suite
5. Add connect task: Add "connect": "deno --allow-env --allow-sys --allow-read --allow-ffi --allow-net run scripts/connect.ts" to deno.json
6. Clean up commented code: Either remove or document why it exists
7. Add error handling: Improve robustness in server.ts and connect.ts

📚 Documentation

The README follows the template well but has one issue:

• Instructions reference deno task connect which isn't defined in deno.json

✅ What Works Well

• Clean, minimal actor implementation
• Proper RivetKit patterns and conventions
• Good project structure
• Comprehensive TypeScript configuration
• Clear separation of concerns between server and client

This example has good bones but needs the above fixes to meet RivetKit's example standards and provide a working demonstration for users.

Claude finished @abcxff's task —— View job

Claude finished reviewing the Deno counter example ✅

Todo List:

• Read and analyze all changed files
• Review against RivetKit development guidelines
• Check example structure and naming conventions
• Evaluate Deno-specific implementation
• Assess security considerations
• Review test coverage and quality
• Provide comprehensive feedback

🔍 Overall Assessment

This is a solid Deno example that demonstrates RivetKit basics with a simple counter actor. The implementation follows most RivetKit conventions but has several issues that need attention.

🚨 Critical Issues

1. Package Naming Convention Violation (examples/deno/package.json:3)

   "name": "example-counter-deno"  // ❌ Should be "example-deno"

   Per CLAUDE.md guidelines: "Always name the example example-{name}"

2. Missing turbo.json File
   All examples should include a turbo.json file with the specified content from CLAUDE.md.

3. Missing connect task in deno.json (examples/deno/deno.json)

   • No connect task defined despite README referencing deno task connect
   • README instructions won't work as written

🧪 Test Coverage Issues

1. All Tests Commented Out (examples/deno/tests/deno.test.ts:1-47)

   • The entire test suite is commented out, providing zero test coverage
   • Tests appear functional but are disabled without explanation
   • This violates the expectation of working examples

2. Missing Test Dependencies (examples/deno/package.json)

   • No test-related dependencies declared despite having test files
   • The commented tests import from jsr:@std/assert but it's not in dependencies

⚠️ Code Quality Issues

1. Inconsistent Script Implementation (examples/deno/scripts/connect.ts:4-20)

   • Contains commented-out code with event handling functionality
   • Current implementation lacks the event listening demo from the commented version
   • Should either remove commented code or explain why it's there

2. Dependency Structure Issues

   • Good: Uses workspace:* for rivetkit dependency (follows guidelines)
   • Unclear: Has both package.json and deno.json with overlapping scripts

🔧 Best Practices & Performance

Positives:

• Clean actor implementation with proper state management
• Correct use of broadcast for event emission (examples/deno/src/registry.ts:10)
• Appropriate Deno permissions in scripts
• Good TypeScript configuration with strict mode
• Proper imports using rivetkit client patterns

Areas for Improvement:

• Consider adding error handling in the increment action
• The server startup could benefit from error handling and logging

🛡️ Security Assessment

Good:

• Minimal, appropriate Deno permissions requested
• No hardcoded secrets or sensitive data
• Proper type safety with TypeScript strict mode

Concerns:

• The broad --allow-net permission could be more restrictive for a local example
• Consider documenting why each permission is needed

📋 Recommendations

1. Fix naming convention: Rename package to example-deno
2. Add missing turbo.json with the required configuration
3. Enable tests: Uncomment and fix the test suite
4. Add connect task: Add "connect": "deno --allow-env --allow-sys --allow-read --allow-ffi --allow-net run scripts/connect.ts" to deno.json
5. Clean up commented code: Either remove or document why it exists
6. Add error handling: Improve robustness in server.ts and connect.ts

📚 Documentation

The README follows the template well but has one issue:

• Instructions reference deno task connect which isn't defined in deno.json

✅ What Works Well

• Clean, minimal actor implementation
• Proper RivetKit patterns and conventions
• Good project structure
• Comprehensive TypeScript configuration
• Clear separation of concerns between server and client

This example has good bones but needs the above fixes to meet RivetKit's example standards and provide a working demonstration for users.

Claude finished @abcxff's task —— View job

Claude finished @abcxff's task —— View job

Code Review Complete ✅

I've reviewed the Deno counter example implementation. Here's my comprehensive feedback:

Todo List:

• Read and analyze all changed files
• Review against RivetKit development guidelines
• Check example structure and naming conventions
• Evaluate Deno-specific implementation
• Assess security considerations
• Review test coverage and quality
• Provide comprehensive feedback

🔍 Overall Assessment

This is a solid Deno example that demonstrates RivetKit basics with a simple counter actor. The implementation follows most RivetKit conventions but has several issues that need attention.

🚨 Critical Issues

1. Package Naming Convention Violation (examples/deno/package.json:3)

   "name": "example-counter-deno"  // ❌ Should be "example-deno" 

   Per CLAUDE.md guidelines: "Always name the example example-{name}"

2. Missing turbo.json File
   All examples should include a turbo.json file with the specified content from CLAUDE.md:

   {
     "$schema": "https://turbo.build/schema.json", 
     "extends": ["//"]
   }

3. Dependency Declaration Issue (examples/deno/package.json:19)

   "rivetkit": "workspace:*"  // ✅ This is actually correct now

   (Fixed from previous version - good!)

🧪 Test Coverage Issues

1. All Tests Commented Out (examples/deno/tests/deno.test.ts:1-47)

   • The entire test suite is commented out, providing zero test coverage
   • Tests appear functional but are disabled without explanation
   • This violates the expectation of working examples

2. Missing Test Dependencies (examples/deno/package.json)

   • No test-related dependencies declared despite having test files
   • The commented tests import from jsr:@std/assert but it's not in dependencies

⚠️ Code Quality Issues

1. README Installation Instructions Issue (examples/deno/README.md:20)

   deno install  // ❌ Should be "npm install" per template

   Per CLAUDE.md template: "npm install" should be used consistently

2. Incorrect Task Reference (examples/deno/README.md:26,32)

   • References deno task dev and deno task connect
   • But package.json scripts use npm-style scripts, not deno tasks
   • Instructions won't work as written

3. Missing Script Handling

   • README references scripts that exist in deno.json but instructions suggest using npm run

🔧 Best Practices & Performance

Positives:

• Clean actor implementation with proper state management (src/registry.ts:3-17)
• Correct use of broadcast for event emission (src/registry.ts:10)
• Appropriate Deno permissions in scripts and tasks
• Good TypeScript configuration with strict mode (tsconfig.json:37)
• Proper workspace dependency usage (package.json:19)

Areas for Improvement:

• Consider adding error handling in the increment action
• The server startup could benefit from error handling and logging

🛡️ Security Assessment

Good:

• Minimal, appropriate Deno permissions requested
• No hardcoded secrets or sensitive data
• Proper type safety with TypeScript strict mode
• Appropriate use of --allow-* flags for specific needs

Concerns:

• The broad permission set could be documented for clarity
• Consider if all permissions are truly needed for this simple example

📋 Recommendations

1. Fix naming convention: Rename package to example-deno
2. Add missing turbo.json with the required configuration
3. Enable tests: Uncomment and fix the test suite, add proper dependencies
4. Fix README instructions: Use consistent npm vs deno task approach
5. Clean up task definitions: Align package.json scripts with deno.json tasks
6. Add error handling: Improve robustness in server.ts

📚 Documentation

The README follows the template structure well but has inconsistencies:

• Installation uses deno install instead of npm install
• Task references are inconsistent between npm scripts and deno tasks

✅ What Works Well

• Clean, minimal actor implementation following RivetKit patterns
• Proper separation of concerns between server and client (src/server.ts:1-3, scripts/connect.ts:4-17)
• Good project structure matching other examples
• Comprehensive TypeScript configuration
• Correct workspace dependency usage (fixed from previous review)
• Appropriate use of Deno-specific features and permissions

This example demonstrates RivetKit fundamentals well but needs the above fixes to meet the project's example standards and provide a working demonstration for users.

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/actor@1291

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/cloudflare-workers@1291

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/core@1291

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/db@1291

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/framework-base@1291

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/next-js@1291

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/react@1291

pnpm add https://pkg.pr.new/rivet-dev/rivetkit@1291

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/sql-loader@1291

commit: 6c06972

Claude finished @abcxff's task —— View job

Claude finished reviewing the Deno counter example ✅

Todo List:

• Read RivetKit development guidelines from CLAUDE.md
• Analyze all changed files in the deno example
• Review against naming conventions and structure requirements
• Check code quality and implementation patterns
• Assess security considerations
• Review test coverage and quality
• Compare with other examples for consistency
• Provide comprehensive feedback

🔍 Overall Assessment

This is a solid Deno example that demonstrates RivetKit basics with a simple counter actor. The implementation follows most RivetKit conventions but has several issues that need attention.

🚨 Critical Issues

1. Missing turbo.json File
   All examples should include a turbo.json file per CLAUDE.md requirements:

   {
     "$schema": "https://turbo.build/schema.json",
     "extends": ["//"]
   }

2. README Installation Instructions Issue (examples/deno/README.md:20)

   deno install  // ❌ Should be "npm install" per template

   Per CLAUDE.md template, installation should use npm install consistently across examples.

3. Task/Script Inconsistency

   • README references deno task dev and deno task connect (README.md:26,32)
   • But instructions suggest using npm-style commands
   • Creates confusion about which command system to use

🧪 Test Coverage Issues

1. All Tests Commented Out (examples/deno/tests/deno.test.ts:1-47)

   • The entire test suite is commented out, providing zero test coverage
   • Tests appear functional but are disabled without explanation
   • This violates the expectation of working examples

2. Missing Test Dependencies

   • The commented tests import from jsr:@std/assert but it's not in dependencies
   • No working test infrastructure despite having test files

🔧 Code Quality & Best Practices

Positives:

• Correct Naming Convention: Package named example-deno following CLAUDE.md guidelines (package.json:3)
• Proper Dependencies: Uses workspace:* for rivetkit dependency (package.json:19)
• Clean Actor Implementation: Well-structured counter actor with proper state management (src/registry.ts:3-17)
• Correct Event Broadcasting: Uses c.broadcast("newCount", c.state.count) properly (src/registry.ts:10)
• Good TypeScript Configuration: Strict mode enabled with appropriate Deno settings (tsconfig.json:37)
• Minimal Server Setup: Clean, simple server startup (src/server.ts:1-3)

Areas for Improvement:

• Consider adding error handling in the increment action
• The server startup could benefit from logging startup confirmation

🛡️ Security Assessment

Good:

• Minimal, appropriate Deno permissions requested
• No hardcoded secrets or sensitive data
• Proper type safety with TypeScript strict mode
• Deno permissions are granular: --allow-env --allow-sys --allow-read --allow-ffi --allow-net

Neutral:

• The permissions are appropriate for this example's needs
• No security concerns identified

📋 Recommendations

1. Add missing turbo.json with the required configuration from CLAUDE.md
2. Fix README installation instructions: Use npm install consistently
3. Clarify task system: Either use npm scripts OR deno tasks, not both confusingly
4. Enable tests: Uncomment and fix the test suite, add proper dependencies
5. Add error handling: Improve robustness in server.ts and actions

📚 Documentation Quality

The README follows the template structure well but has inconsistencies:

• Uses deno install instead of npm install in installation section
• Task references create confusion between npm and deno command styles
• Otherwise follows CLAUDE.md template correctly

✅ What Works Well

• Proper RivetKit Patterns: Demonstrates actor creation, state management, and client interaction correctly
• Clean Architecture: Good separation between registry, server, and client scripts
• Appropriate Deno Integration: Uses Deno-specific features appropriately with proper imports
• Type Safety: Full TypeScript integration with proper typing
• Workspace Integration: Correctly uses workspace dependencies

📊 Comparison with Standard Counter Example

The implementation closely mirrors the standard counter example but adapts well to Deno:

• Same actor logic and patterns
• Appropriate runtime-specific configurations
• Similar project structure and organization

This example demonstrates RivetKit fundamentals well but needs the above fixes to meet the project's example standards and provide a working demonstration for users.

Claude finished @abcxff's task —— View job

Claude has completed reviewing the Deno counter example ✅

Todo List:

• Read RivetKit development guidelines from CLAUDE.md
• Analyze all changed files in the deno example
• Review against naming conventions and structure requirements
• Check code quality and implementation patterns
• Assess security considerations
• Review test coverage and quality
• Compare with other examples for consistency
• Address specific review comments from maintainers
• Provide comprehensive feedback

🔍 Overall Assessment

This Deno example demonstrates RivetKit fundamentals well and shows proper runtime-specific implementation. However, there are several critical issues that need to be addressed before merging.

🚨 Critical Issues

1. Missing turbo.json File

   • Required by CLAUDE.md guidelines: "All examples should have the turbo.json"
   • Should contain:

   {
     "$schema": "https://turbo.build/schema.json",
     "extends": ["//"]
   }

2. README Installation Instructions Inconsistency (examples/deno/README.md:20)

   pnpm install  # ❌ Conflicts with CLAUDE.md template which shows "npm install"

   • CLAUDE.md template consistently shows npm install for all examples
   • Creates inconsistency with project standards

3. Task System Confusion (examples/deno/README.md:28,34)

   • README references deno task dev and deno task connect
   • But also mentions pnpm/npm installation
   • Mixed approach creates confusion about which command system to use

⚠️ Missing Functionality

1. No Test Coverage

   • No test files present (other examples like counter have vitest tests)
   • deno.json includes a test task but no tests exist
   • Missing opportunity to demonstrate RivetKit testing patterns

2. Missing WebSocket Upgrade Implementation

   • Reviewer NathanFlurry specifically requested: "need to add custom upgrade web socket"
   • Current implementation at src/server.ts:8 uses basic upgradeWebSocket from Hono
   • May need custom WebSocket upgrade logic

🔧 Code Quality Assessment

Excellent:

• Correct Naming Convention: example-deno follows CLAUDE.md guidelines (package.json:3)
• Proper Dependencies: Uses workspace:* for rivetkit dependency (package.json:19)
• Clean Actor Implementation: Well-structured counter actor with proper state management (src/registry.ts:3-17)
• Correct Event Broadcasting: Properly uses c.broadcast("newCount", c.state.count) (src/registry.ts:10)
• TypeScript Configuration: Strict mode enabled with appropriate Deno settings (tsconfig.json:37)
• Deno-Specific Features: Proper use of Deno.serve and Deno permissions

Good:

• Permission Management: Uses --allow-all in package.json scripts for simplicity (as requested by NathanFlurry: "update to include allow all")
• Runtime Adaptation: Properly adapts RivetKit for Deno runtime with disableServer: true and custom WebSocket upgrade

Needs Improvement:

• Error Handling: No error handling in increment action or server startup
• Logging: Missing startup confirmation or error logging

🛡️ Security Assessment

Acceptable:

• Uses --allow-all permissions as requested by maintainer
• No hardcoded secrets or sensitive data
• Proper type safety with TypeScript strict mode

Note: While --allow-all is broad, the maintainer specifically requested this approach.

📋 Addressing Review Comments

NathanFlurry's Requests:

1. ✅ "update to include allow all" - Fixed in package.json scripts
2. ❌ "need to add custom upgrade web socket" - Still uses basic Hono upgradeWebSocket
3. ❌ "kill it" (referring to tests) - No tests were present to remove

Graphite App's Comment:

• ❌ Test script permissions - No test script exists in package.json to update

📚 Documentation Issues

1. Installation Inconsistency: Uses pnpm install instead of template's npm install
2. Task References: Commands in README don't align with dual command approach
3. Missing Context: Doesn't explain why both package.json and deno.json exist

✅ What Works Well

• Clean Architecture: Good separation between registry, server, and client
• RivetKit Integration: Demonstrates actor patterns, state management, and client interaction correctly
• Deno Adaptation: Shows how to adapt RivetKit for different runtimes effectively
• Simple Demonstration: Provides clear, minimal example of core functionality

🎯 Recommendations

1. Add missing turbo.json with required configuration
2. Standardize installation instructions to use npm install per template
3. Implement custom WebSocket upgrade as requested by maintainer
4. Add test coverage to demonstrate testing patterns
5. Clarify dual command system in README or choose one approach
6. Add error handling for robustness

📊 Comparison with Counter Example

The Deno example closely mirrors the standard counter but appropriately adapts for Deno runtime. It follows the same patterns but lacks the test coverage present in other examples.

This example has solid foundations but needs the above fixes to meet RivetKit's standards and address maintainer feedback.

Claude finished @abcxff's task —— View job

Code Review Complete ✅

I've conducted a comprehensive review of the Deno counter example implementation against RivetKit development guidelines and best practices.

Todo List:

• Read RivetKit development guidelines from CLAUDE.md
• Analyze all changed files in the deno example
• Review against naming conventions and structure requirements
• Check code quality and implementation patterns
• Assess security considerations
• Review test coverage and quality
• Compare with other examples for consistency
• Provide comprehensive feedback

🔍 Overall Assessment

This Deno example demonstrates solid RivetKit fundamentals with a clean counter actor implementation. While the core functionality is well-implemented, there are several critical issues that violate RivetKit conventions and prevent it from being a complete working example.

🚨 Critical Issues

1. Missing Required turbo.json File

   • Issue: All examples must include a turbo.json file per CLAUDE.md requirements
   • Expected: ```json
     {
     "$schema": "https://turbo.build/schema.json",
     "extends": ["//"]
     }

   • Impact: Breaks Turborepo build system integration

2. README Installation Instructions Inconsistency (examples/deno/README.md:20)

   • Issue: Uses pnpm install instead of standardized npm install
   • Expected: Per CLAUDE.md template, should consistently use npm install across all examples
   • Impact: Creates confusion for users following documentation

3. Dual Task System Confusion

   • Issue: Both package.json scripts and deno.json tasks exist with overlapping functionality
   • Problem: README references deno task dev/connect but package.json has different script definitions
   • Impact: Instructions unclear and potentially non-functional

🧪 Test Coverage Issues

1. No Test Infrastructure
   • Issue: No test files present, unlike other examples (e.g., counter example has vitest)
   • Missing: Test framework setup and example tests
   • Impact: Users can't learn testing patterns with RivetKit

⚠️ Code Quality & Convention Issues

1. Overly Broad Permissions (examples/deno/package.json:8,10)

   • Current: --allow-all flag used everywhere
   • Better: Granular permissions like in deno.json (--allow-env --allow-sys --allow-read --allow-ffi --allow-net)
   • Security: Current approach violates principle of least privilege

2. Script/Task Duplication

   • Issue: Scripts exist in both package.json and deno.json with different permission sets
   • Confusion: Users don't know which system to use

🔧 Code Quality Strengths

✅ Excellent Core Implementation:

• Actor Definition (src/registry.ts:3-17): Clean, follows RivetKit patterns perfectly
• Event Broadcasting (src/registry.ts:10): Correct use of c.broadcast("newCount", c.state.count)
• Client Usage (scripts/connect.ts:7-14): Proper client connection and RPC patterns
• Deno Integration (src/server.ts:1-12): Appropriate use of Deno-specific WebSocket upgrade and server

✅ Proper Conventions:

• Naming: Package correctly named example-deno (follows CLAUDE.md)
• Dependencies: Uses workspace:* for rivetkit dependency (correct)
• TypeScript: Strict mode enabled with appropriate Deno configuration
• Project Structure: Follows standard example layout

🛡️ Security Assessment

Good:

• No hardcoded secrets or sensitive data
• Type safety with strict TypeScript
• Minimal attack surface in example code

Concerns:

• --allow-all permissions are overly broad for a simple example
• Should use granular permissions like deno.json demonstrates

📊 Performance Considerations

Good:

• Minimal, efficient actor implementation
• Appropriate use of Deno's native features
• Clean server startup with proper WebSocket handling

No Significant Issues: The example is appropriately simple and performant.

📋 Specific Recommendations

1. Add missing turbo.json with required configuration
2. Standardize installation instructions to use npm install
3. Consolidate task systems - choose either package.json OR deno.json tasks, not both
4. Replace --allow-all with granular permissions from deno.json
5. Add test framework (consider Deno's built-in test runner)
6. Clarify runtime choice in README (explain when to use Deno vs Node.js)

📚 Documentation Quality

Follows Template Well:

• Correct title format and project links
• Proper Getting Started structure
• Appropriate license section

Issues:

• Installation command inconsistency
• Task reference confusion

✅ What Works Exceptionally Well

• Perfect Actor Patterns: Demonstrates state management, actions, and events correctly
• Excellent Deno Integration: Shows proper WebSocket upgrade and server setup for Deno
• Clean Code Structure: Well-organized, readable implementation
• Type Safety: Full TypeScript integration with proper Deno types
• Workspace Integration: Correct dependency management

🎯 Comparison with Standard Counter Example

The Deno example successfully adapts the standard counter pattern while adding appropriate Deno-specific features. The core logic is identical (which is good for consistency), but the server setup appropriately uses Deno's upgradeWebSocket and Deno.serve.

Summary: This is a solid foundation that demonstrates RivetKit's Deno compatibility well. The core implementation is excellent, but it needs the above structural fixes to meet RivetKit's example standards and provide a complete, working demonstration for users.

Merge activity

• Oct 4, 9:00 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
• Oct 4, 9:00 PM UTC: CI is running for this pull request on a draft pull request (#1343) due to your merge queue CI optimization settings.
• Oct 4, 9:01 PM UTC: Merged by the Graphite merge queue via draft PR: #1343.